-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for specifying C/C++ standard version #761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me.
There are conflicts I guess. Can you rebase? |
Sure, I can do that later today. Maybe I can take that opportunity to edit the doc comment a bit to address the review comment above. |
Sure. I think it's fine as-is but additional clarification wouldn't hurt. |
I rebased it now. The conflict was caused by the code being changed to use |
Thanks. |
Thanks for taking the time to review and merge this! :) |
As requested by #565.
Please have a look at the documentation I have included. :)
I am not doing any abstraction over special cases like the name for the work-in-progress standard version. It's just the basics.
I want to propose adding this to
cc
because:cc
crate, the developer has to write conditional, platform-specific code.