Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt synstructure for our custom derives #381

Closed
nikomatsakis opened this issue Apr 7, 2020 · 2 comments · Fixed by #387
Closed

adopt synstructure for our custom derives #381

nikomatsakis opened this issue Apr 7, 2020 · 2 comments · Fixed by #387
Assignees
@rustbot

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Apr 7, 2020 •
edited by rustbot
Loading

Our custom derive code could maybe be made cleaner by using the synstructure crate -- but let's wait until we've landed #373

This issue has been assigned to @Areredify via this comment.
@detrumi
Copy link
Member

detrumi commented Apr 7, 2020

We should take inspiration from rustc: https://github.com/rust-lang/rust/blob/master/src/librustc_macros/src/type_foldable.rs

(discussion in Zulip)

@basil-cow
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this Apr 11, 2020
@basil-cow basil-cow mentioned this issue Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use synstructure in derives basil-cow/chalk
4 participants
@nikomatsakis @detrumi @basil-cow @rustbot