Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutable references should not be Copy/Clone #447

Merged
merged 5 commits into from
May 9, 2020
Merged

Mutable references should not be Copy/Clone #447

merged 5 commits into from
May 9, 2020

Conversation

nathanwhit
Copy link
Member

Closes #438.

jackh726
jackh726 requested changes May 9, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! Can you also add tests that mutable refs are sized and well formed?

@nathanwhit nathanwhit force-pushed the typename-mutref-fix branch from 11d1de0 to 1400be4 Compare May 9, 2020 23:22
@nathanwhit
Copy link
Member Author

Done!

@jackh726 jackh726 merged commit adec469 into rust-lang:master May 9, 2020
@nathanwhit nathanwhit deleted the typename-mutref-fix branch May 25, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create TypeName for & and &mut
2 participants
@nathanwhit @jackh726