Add implied bounds #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
requested changes
Sep 28, 2017
src/lower/mod.rs
Outdated
| // we generate the following clause: | ||
| // | ||
| // for<?T> WF(Foo<?T>) :- WF(?T), (?T: Eq), WF(?T: Eq). | ||
| macro_rules! well_formed { |
There was a problem hiding this comment.
It would be nice to have a comment explaining what this does =)
| } | ||
|
|
||
| // Here, we do know that `T: Clone`, so we can. | ||
| // Here, we do know that `T: Eq`, so we can. |
| } | ||
|
|
||
| impl<T: ExpandWhereClauses> WellFormed for ir::Binders<T> { | ||
| fn wf_clauses(&self, wf_predicate: ir::WellFormed, program: &ir::Program) |
There was a problem hiding this comment.
I definitely prefer this to the macro, but I'd still like some comments. =)
src/lower/mod.rs
Outdated
| tys.chain(where_clauses.iter().cloned().casted()).collect() | ||
| } | ||
| consequence: wf_predicate.clone().cast(), | ||
| conditions: where_clauses.iter().cloned().casted().collect(), |
There was a problem hiding this comment.
in particular it's not obvious to me what has changed in this commit other than tests, just looking at the code anyhow
|
Closing in favor of #82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add implied bounds on structs and remove WF conditions for type parameters in WF predicates, e.g. before this PR we had:
and after this PR: