Implement all the 128-bit operator lang items (Rust 45676 part 2) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
est31
reviewed
Nov 25, 2017
src/int/add.rs
Outdated
|
|
||
| #[test] | ||
| fn test_add() { | ||
| assert_eq!(rust_u128_add(1, 2), 3); |
There was a problem hiding this comment.
you should put those into the tests/ directory, that's where all the other tests are. I guess one doesn't need to go the full way that most of the other tests do by autogenerating values though.
scottmcm
force-pushed
the
add-128bit-lang-items
branch
from
ade18a5 to
bcc41a9
Compare
(I really don't understand how arithmetic makes it segfault...)
|
Thanks @scottmcm! Additionally thanks for the tests! Everything here looks fantastic to me |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…s, r=nagisa Update compiler-builtins and use it in the 128-bit lowering MIR test This picks up the lang item implementations from rust-lang/compiler-builtins#210 cc rust-lang#45676 @est31 @nagisa
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…s, r=nagisa Update compiler-builtins and use it in the 128-bit lowering MIR test This picks up the lang item implementations from rust-lang/compiler-builtins#210 cc rust-lang#45676 @est31 @nagisa
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…s, r=nagisa Update compiler-builtins and use it in the 128-bit lowering MIR test This picks up the lang item implementations from rust-lang/compiler-builtins#210 cc rust-lang#45676 @est31 @nagisa
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Nov 30, 2017
…s, r=nagisa Update compiler-builtins and use it in the 128-bit lowering MIR test This picks up the lang item implementations from rust-lang/compiler-builtins#210 cc rust-lang#45676 @est31 @nagisa
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 3, 2017
Update compiler-builtins and use it in the 128-bit lowering MIR test This picks up the lang item implementations from rust-lang/compiler-builtins#210 cc #45676 @est31 @nagisa
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
Remove most `#[inline]` annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#46093 declared lang items for all the 128-bit operators. This PR implements them.
I was unsure how testing should work, and was unable to get the tests in
/teststo even compile locally.cc rust-lang/rust#45676 @nagisa @est31