Add float quickcheck implementations (fixes #45) #48
Conversation
mattico
force-pushed
the
add_float_quickcheck
branch
2 times, most recently
from
fbb4deb to
a6d1ba7
Compare
|
Interesting test failure here: Slightly different results, possibly a rounding error? Intriguing that it's the (only?) soft float target which has issues |
|
|
||
| // Generates values in the full range of the integer type | ||
| macro_rules! arbitrary { | ||
| ($TY:ident : $ty:ident) => { | ||
| ($id:ident: $ty:ty) => { |
There was a problem hiding this comment.
I forgot that I left these changes in the commit. I can remove them if you prefer the current style.
There was a problem hiding this comment.
I would prefer to maintain the status quo for now just to reduce the noise in the diff. I don't have a strong preference for the name of the macro arguments.
mattico
force-pushed
the
add_float_quickcheck
branch
2 times, most recently
from
4b6f32b to
8b135b3
Compare
|
Interesting that only soft float arm target failed. That means that these intrinsics match the output of hardware instructions (the hard float arm targets pass) but don't match the output of libcompiler-rt.a's intrinsics? |
mattico
force-pushed
the
add_float_quickcheck
branch
2 times, most recently
from
496d10b to
28e5fe4
Compare
|
☔ The latest upstream changes (presumably #67) made this pull request unmergeable. Please resolve the merge conflicts. |
mattico
force-pushed
the
add_float_quickcheck
branch
from
28e5fe4 to
831074e
Compare
|
I mostly just want to see if this works... |
|
@mattico ah sorry homu is currently configured to only let me "try". Mostly because changing that default configuration is annoying :P. @homunkulus try |
|
@homunkulus try (homu was out of sync :X) |
|
💔 Test failed - status-appveyor |
mattico
force-pushed
the
add_float_quickcheck
branch
3 times, most recently
from
48b9a80 to
0180f60
Compare
|
Rebased |
mattico
force-pushed
the
add_float_quickcheck
branch
2 times, most recently
from
8ba160f to
a6c25f8
Compare
|
Rebased on #74. Should be mergable now. |
mattico
force-pushed
the
add_float_quickcheck
branch
from
fe11774 to
010d153
Compare
|
@homunkulus try |
|
☀️ Test successful - status-appveyor, status-travis |
|
Awesome @mattico! |
|
@japaric so is the plan to merge this into rust-lang/rust before doing more work on it? |
|
I'm going to try to land this in rust-lang/rust, yeah. But feel free to keep working on it in the mean time 👍. |
|
@mattico could you re-send this PR? |
This builds on top of #43 to add Quickcheck helpers for floating point.
I generate a few different types of floats by constructing them from their component parts, using new functions defined on the Float trait. The Add implementation could be refactored to use these new functions for clarity.