Reduce scans of experiment_crates to find next crate #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These scans are relatively expensive, so instead we internally cache a small amount of crates. The expectation is that this should allow us to scan ~once rather than repeatedly re-scanning as time goes by. I experimented with a partial index but didn't get any meaningful results (possibly made things worse), it's not super clear *why*, but the hope is that this is more or less just an improvement.
Mark-Simulacrum
force-pushed
the
debug-crater
branch
from
f85b752 to
5e54664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These scans are relatively expensive, so instead we internally cache a small amount of crates. The expectation is that this should allow us to scan ~once rather than repeatedly re-scanning as time goes by. I experimented with a partial index but didn't get any meaningful results (possibly made things worse), it's not super clear why, but the hope is that this is more or less just an improvement.