Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo update #1756

Merged
merged 2 commits into from
May 30, 2019
Merged

Run cargo update #1756

merged 2 commits into from
May 30, 2019

Conversation

jtgeibel
Copy link
Member

I have several local branches updating dependencies and addressing any
breaking changes (towards closing out #1265). I'd like to avoid
lockfile merge conflicts between those branches so I'm bumping all
semver compatible versions in this PR.

I'd like to let this bake in production for at least a few days before
opening PRs bumping major versions in Cargo.toml.

If this approach is too aggressive, or needs to be reverted, I can open
the other PRs more serially and look into breaking this upgrade into
smaller pieces.

jtgeibel added 2 commits May 29, 2019 22:03
I have several local branches updating dependencies and addressing any
breaking changes (towards closing out rust-lang#1265).  I'd like to avoid
lockfile merge conflicts between those branches so I'm bumping all
semver compatible versions in this PR.

I'd like to let this bake in production for at least a few days before
opening PRs bumping major versions in `Cargo.toml`.

If this approach is too aggressive, or needs to be reverted, I can open
the other PRs more serially and look into breaking this upgrade into
smaller pieces.
Force clear the cache on CI so that cache uploads do not time out.
@sgrif
Copy link
Contributor

sgrif commented May 30, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 30, 2019

📌 Commit 7b32468 has been approved by sgrif

@bors
Copy link
Contributor

bors commented May 30, 2019

⌛ Testing commit 7b32468 with merge 293a3fb...

bors added a commit that referenced this pull request May 30, 2019
Run `cargo update`

I have several local branches updating dependencies and addressing any
breaking changes (towards closing out #1265).  I'd like to avoid
lockfile merge conflicts between those branches so I'm bumping all
semver compatible versions in this PR.

I'd like to let this bake in production for at least a few days before
opening PRs bumping major versions in `Cargo.toml`.

If this approach is too aggressive, or needs to be reverted, I can open
the other PRs more serially and look into breaking this upgrade into
smaller pieces.
@bors
Copy link
Contributor

bors commented May 30, 2019

☀️ Test successful - checks-travis
Approved by: sgrif
Pushing 293a3fb to master...

@bors bors merged commit 7b32468 into rust-lang:master May 30, 2019
sgrif added a commit that referenced this pull request Jun 11, 2019
This reverts commit 293a3fb, reversing
changes made to a6de1e1.

Segfaults began occurring in production after deploying this.
@sgrif
Copy link
Contributor

sgrif commented Jun 11, 2019

I've reverted this on master, it caused segfaults when deployed to production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants