-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run cargo update
#1756
Merged
Merged
Run cargo update
#1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have several local branches updating dependencies and addressing any breaking changes (towards closing out rust-lang#1265). I'd like to avoid lockfile merge conflicts between those branches so I'm bumping all semver compatible versions in this PR. I'd like to let this bake in production for at least a few days before opening PRs bumping major versions in `Cargo.toml`. If this approach is too aggressive, or needs to be reverted, I can open the other PRs more serially and look into breaking this upgrade into smaller pieces.
Force clear the cache on CI so that cache uploads do not time out.
@bors r+ |
📌 Commit 7b32468 has been approved by |
bors
added a commit
that referenced
this pull request
May 30, 2019
Run `cargo update` I have several local branches updating dependencies and addressing any breaking changes (towards closing out #1265). I'd like to avoid lockfile merge conflicts between those branches so I'm bumping all semver compatible versions in this PR. I'd like to let this bake in production for at least a few days before opening PRs bumping major versions in `Cargo.toml`. If this approach is too aggressive, or needs to be reverted, I can open the other PRs more serially and look into breaking this upgrade into smaller pieces.
☀️ Test successful - checks-travis |
I've reverted this on master, it caused segfaults when deployed to production |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have several local branches updating dependencies and addressing any
breaking changes (towards closing out #1265). I'd like to avoid
lockfile merge conflicts between those branches so I'm bumping all
semver compatible versions in this PR.
I'd like to let this bake in production for at least a few days before
opening PRs bumping major versions in
Cargo.toml
.If this approach is too aggressive, or needs to be reverted, I can open
the other PRs more serially and look into breaking this upgrade into
smaller pieces.