Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chrono, dotenv, num-*, migrations_macros, and derive_deref #1917

Merged
merged 4 commits into from
Nov 25, 2019

Conversation

jtgeibel
Copy link
Member

@jtgeibel jtgeibel commented Nov 23, 2019

Overall, this drops 16 old versions of dependencies. The num-* crates are on the list at #1805, but overall I think this is low risk to deploy together.

  • cargo update -p num -p num-iter -p num-traits --aggressive
  • cargo update -p chrono
  • cargo update -p migrations_macros -p derive_deref
  • Update to latest dotenv

@rust-highfive
Copy link

r? @carols10cents

(rust_highfive has picked a reviewer for you, use r? to override)

@jtgeibel
Copy link
Member Author

I've added a commit bumping chrono, because the newer version drops a few deps on old num-* crates and doesn't affect the rest of the dependency tree.

@jtgeibel jtgeibel changed the title Update num crates Update chrono and num crates Nov 23, 2019
This allows us to drop some old versions of `quote`, `syn`, `synom`,
and `unicode-xid`.
@jtgeibel
Copy link
Member Author

I've added a final commit that bumps migrations_macros and derive_deref. This drops some old versions of quote, syn, synom, and unicode-xid! I would have landed this as a separate PR, except there was one small conflict that would need to be rebased and overall I think this PR is still low risk to deploy.

@jtgeibel jtgeibel changed the title Update chrono and num crates Update chrono, num-*, migrations_macros, and derive_deref Nov 23, 2019
@jtgeibel jtgeibel changed the title Update chrono, num-*, migrations_macros, and derive_deref Update chrono, dotenv, num-*, migrations_macros, and derive_deref Nov 23, 2019
@carols10cents
Copy link
Member

Nice!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit 1f25bda has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit 1f25bda with merge b7796c9...

bors added a commit that referenced this pull request Nov 25, 2019
Update chrono, dotenv, num-*, migrations_macros, and derive_deref

Overall, this drops 16 old versions of dependencies.  The `num-*` crates are on the list at #1805, but overall I think this is low risk to deploy together.

* `cargo update -p num -p num-iter -p num-traits --aggressive`
* `cargo update -p chrono`
* `cargo update -p migrations_macros -p derive_deref`
* Update to latest `dotenv`
@bors
Copy link
Contributor

bors commented Nov 25, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing b7796c9 to master...

@bors bors merged commit 1f25bda into rust-lang:master Nov 25, 2019
@jtgeibel jtgeibel deleted the update/num branch December 26, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants