Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudFront invalidation for index files #5200

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

arlosi
Copy link
Contributor

@arlosi arlosi commented Sep 7, 2022

Send invalidation request to CloudFront when a crate is modified.

Does nothing if CLOUDFRONT_DISTRIBUTION isn't set.

Fixes #4913

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Sep 9, 2022
@bors
Copy link
Contributor

bors commented Sep 14, 2022

☔ The latest upstream changes (presumably 25c3bb4) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@jtgeibel jtgeibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! One small suggestion.

src/worker/cloudfront.rs Show resolved Hide resolved
@arlosi
Copy link
Contributor Author

arlosi commented Sep 27, 2022

@jtgeibel I've updated the PR to include your suggestion. Can this be merged?

@jtgeibel jtgeibel merged commit 99810bd into rust-lang:master Oct 5, 2022
@jtgeibel
Copy link
Member

jtgeibel commented Oct 5, 2022

Sorry for the delay. I've just merged and will deploy to staging. I've pinged the infra team about getting the environment variables set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send invalidations for index.crates.io when updating crates
4 participants