Remove async/await crates #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds good to me-- the async/await stuff landed faster than I expected, so I don't think we'll need the macros anymore. Still, it is a bit sad to lose the ability to create streams via generators. cc @withoutboats @aturon Do either of you think that we should keep the macros around (and fix/maintain them) for the sake of stream-generators, or are you okay with killing them? |
|
If anyone wants to maintain the stream generator stuff against futures 0.3 in a separate repo, big 👍 from me, but I don't think they should be a part of the futures crate. |
|
SGTM-- I'll go ahead and merge this then, and they can get pulled out of the history if someone so desires. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need these anymore