Bump libgit2 to 1.4.0 #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
commented
Feb 15, 2022
| @@ -120,7 +120,7 @@ pub use crate::reference::{Reference, ReferenceNames, References}; | |||
| pub use crate::reflog::{Reflog, ReflogEntry, ReflogIter}; | |||
| pub use crate::refspec::Refspec; | |||
| pub use crate::remote::{ | |||
| FetchOptions, PushOptions, Refspecs, Remote, RemoteConnection, RemoteHead, | |||
| FetchOptions, PushOptions, Refspecs, Remote, RemoteConnection, RemoteHead, RemoteRedirect, | |||
There was a problem hiding this comment.
API question: RemoteRedirect or Redirect? The libgit2 enum is called git_remote_redirect_t.
There was a problem hiding this comment.
I think following libgit2 with RemoteRedirect is fine here
|
Would it be possible to bump the version probe here? |
|
@ehuss @alexcrichton yeah lets bump that before we mark a release please |
|
we probably need a release checklist in the readme |
This was referenced Feb 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #804.