Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply suggestions from clippy::ptr_as_ptr #230

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

cole-miller
Copy link

This is a new pedantic lint that triggers on pointer casts with as that don't change mutability. It was preventing #229 from passing CI.

@cole-miller
Copy link
Author

Oh, I guess pointer::cast isn't MSRV-compatible. Maybe it's better to just allow this lint then?

@cole-miller cole-miller changed the title Apply suggestions from clippy::ptr_as_ptr Allow clippy::ptr_as_ptr Jan 19, 2021
@Amanieu
Copy link
Member

Amanieu commented Jan 20, 2021

We're going to make a breaking change on the next release anyways, so it's fine to bump the MSRV.

@cole-miller cole-miller changed the title Allow clippy::ptr_as_ptr Apply suggestions from clippy::ptr_as_ptr Jan 21, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@Amanieu
Copy link
Member

Amanieu commented Jan 21, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2021

📌 Commit 5fa1701 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Jan 21, 2021

⌛ Testing commit 5fa1701 with merge f9b3183...

@bors
Copy link
Contributor

bors commented Jan 21, 2021

☀️ Test successful - checks-travis
Approved by: Amanieu
Pushing f9b3183 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants