-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add try_insert_no_grow
method on RawTable
#229
Conversation
0917017
to
1316b35
Compare
Fixed the unused warning by adding The latest CI failure seems to be due to a (new?) Clippy lint |
That's the correct solution. Code LGTM, just need to wait for #230 to land first. |
Apply suggestions from `clippy::ptr_as_ptr` This is a new pedantic lint that triggers on pointer casts with `as` that don't change mutability. It was preventing #229 from passing CI.
1316b35
to
ac65b9f
Compare
@bors r+ |
📌 Commit 92677e0 has been approved by |
☀️ Test successful - checks-travis |
Thanks! |
This is my attempt to answer the need described in #224 by adding a method on
RawTable
:This method follows the logic of
RawTable::insert
, but if the table would need to grow to accomodate the new element it "signals" by returningErr(value)
instead of performing the reallocation and insertion.Marked as draft for now because
pub
) that I haven't figured out how to get rid of