Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Notes on comparison #111

Merged
merged 1 commit into from
Aug 7, 2019
Merged

README: Notes on comparison #111

merged 1 commit into from
Aug 7, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 7, 2019

When hashers with different design goals are compared, that should be noted. Otherwise this compares apples with oranges.

@Amanieu Amanieu merged commit bacb169 into rust-lang:master Aug 7, 2019
@CryZe
Copy link
Contributor

CryZe commented Aug 7, 2019

Doesn't ahash provides HashDOS resistance too? They use various sources of randomness and pull that into their seed and they even say it's HashDOS resistant like SipHash in their README.

@Amanieu
Copy link
Member

Amanieu commented Aug 7, 2019

I don't think it has been cryptographically proven to be HashDOS resistant...

@CryZe
Copy link
Contributor

CryZe commented Aug 7, 2019

Yeah that's true

@RalfJung RalfJung deleted the readme branch August 7, 2019 20:50
@RalfJung
Copy link
Member Author

RalfJung commented Aug 7, 2019

Yeah, to my knowledge aHash has not been subject to any independent cryptographic analysis. Without such an analysis, I wouldn't trust any cryptographic claims.

It is undoubtedly much closer to HashDoS resistant than FxHash, but that's not the same thing.

@RalfJung
Copy link
Member Author

Looks like this note was lost at some point... the README now again advertises hashbrown in a way that does not mention that switching from the standard HashMap to this, one will lose DoS resistance. (I consider any such claims about aHash to be highly speculative, so each user should decide for themselves if they consider this 'good enough'.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants