-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #483 - japaric:sparc64, r=alexcrichton
sparc64-linux support This needs to be "cleaned" up to use modules instead of a bunch of `cfg`s ... Sadly, sparc64 constants are very different from other architectures so cleaning this will result in a bunch of duplication, I think. While working on this, I was wondering why the constants are not written like this: ``` rust // linux/mod.rs const COMMON: ::c_int = 3; cfg_if! { if #[cfg(target_arch = "sparc64")] { const FOO: ::c_int = 1; } else if #[cfg(any(target_arch = "mips64", target_arch = "x86_64"))] { const FOO: ::c_int = 2; } else { // unsupported/unknown architecture } } ``` I think this might result in less duplicated code. @alexcrichton Has something like that ^ been attempted before?
- Loading branch information
Showing
13 changed files
with
1,312 additions
and
194 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.