Add AF_ALG constants and structures #1261
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit 32226f5 has been approved by |
|
@bors: r- |
|
Tests which explicitly download the kernel version 3.12.6 are failing. Minimum kernel version 3.19 is required for |
The best would be to skip these in the |
|
The build is passing now. Would you review the code again? |
|
Should be good now |
src/unix/notbsd/android/mod.rs
Outdated
| .field("salg_type", &self.salg_type) | ||
| .field("salg_feat", &self.salg_feat) | ||
| .field("salg_mask", &self.salg_mask) | ||
| // .field("salg_name", &self.salg_name) |
There was a problem hiding this comment.
this and anothr field below are also commented, would you mind fixing those too?
This reverts commit ae2663a.
src/unix/notbsd/linux/mod.rs
Outdated
| @@ -748,7 +748,7 @@ cfg_if! { | |||
| impl ::fmt::Debug for af_alg_iv { | |||
| fn fmt(&self, f: &mut ::fmt::Formatter) -> ::fmt::Result { | |||
| f.debug_struct("af_alg_iv") | |||
| // .field("iv", self.as_slice()) | |||
| .field("iv", &self.as_slice().iter().collect::<Vec<_>>()) | |||
There was a problem hiding this comment.
I think that &self.as_slice() should be enough, no need to call iter and collect (which would allocate memory).
|
@bors: r+ |
|
📌 Commit bce3ee3 has been approved by |
Add AF_ALG constants and structures
|
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
No description provided.