-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AIX operating system #2894
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
Also, please fix the style check failure. |
Marking as blocked until rust-lang/compiler-team#553 is approved. |
☔ The latest upstream changes (presumably #3038) made this pull request unmergeable. Please resolve the merge conflicts. |
b5bbe2c
to
5b9605a
Compare
Can we push this forward now? (since this is essential crate for nearly all crates) |
The last request was
So if you take care of that last bit I can make sure this happens! |
This change adds rather complete definitions and declarations from AIX system headers, with little modification to fit the assumption in some crates or other targets in libc. Currently only 64-bit PowerPC targets on AIX are proposed, so definitions depending on pointer width are located in powerpc64 module. Thanks to initial work from Etienne Guesnet, this patch is based on it (rust-lang#2278).
Ah, thanks. I thought this would be done by the GitHub button. |
Well everyone has different feelings about how that should go, but mostly, bors does the merges around here! And since all the requirements laid out were fulfilled, I am happy to be DoppelTitor. I think I have the authority to do that now. @bors r=JohnTitor |
Aha, I do! |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This PR adds rather complete definitions and declarations from AIX system headers, with little modification to fit the assumption in some crates or other targets in libc.
Currently only 64-bit PowerPC targets on AIX are proposed, so definitions depending on pointer width are located in
powerpc64
module.This one should be successor of #2278 (and thanks to @EGuesnet 's initial work).