-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenBSD CLOCK_* constants #3146
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Some changes occurred in OpenBSD module cc @semarie |
both without them (from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you squash commits into one? |
Done |
It doesn't seem to be squashed, see this guide on how you can "squash" commits into one if you're unfamiliar with Git. |
- src/unix/bsd/netbsdlike/openbsd/mod.rs: add CLOCK_* constants from /usr/include/sys/_time.h - libc-test/semver/openbsd.txt: update file for new constants CLOCK_* Signed-off-by: Laurent Cheylus <[email protected]>
OK, fix my commit and remove merge to comply with the "no merge" policy. |
Thanks a lot! @bors r+ |
Add OpenBSD CLOCK_* constants To compile [`wasmer-wasi`](https://github.com/wasmerio/wasmer/tree/master/lib/wasi) crate (part of Wasmer) on OpenBSD, I need to add CLOCK_* constants from `/usr/include/sys_time.h` file. - Add CLOCK_* constants in `src/unix/bsd/netbsdlike/openbsd/mod.rs` - Update `libc-test/semver/openbsd.txt` accordingly cc `@semarie`
💔 Test failed - checks-actions |
homu failed due to network error:
|
@bors retry |
Add OpenBSD CLOCK_* constants To compile [`wasmer-wasi`](https://github.com/wasmerio/wasmer/tree/master/lib/wasi) crate (part of Wasmer) on OpenBSD, I need to add CLOCK_* constants from `/usr/include/sys_time.h` file. - Add CLOCK_* constants in `src/unix/bsd/netbsdlike/openbsd/mod.rs` - Update `libc-test/semver/openbsd.txt` accordingly cc `@semarie`
💔 Test failed - checks-actions |
Another network failure, @bors retry |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
To compile
wasmer-wasi
crate (part of Wasmer) on OpenBSD, I need to add CLOCK_* constants from/usr/include/sys_time.h
file.src/unix/bsd/netbsdlike/openbsd/mod.rs
libc-test/semver/openbsd.txt
accordinglycc @semarie