-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: add reboot() and constants #333
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Copy them into individual platform files instead. Fixes musl build.
Should the rest of reboot declarations be in |
If they're shared among all the platforms under |
I'm not really sure whether the same stuff is available under Android: Android is Linux anyway, but it may well be glibc-specific stuff. |
OK, so it does break the Android build. Reverting. |
Feel free to merge this (or should we play the rebasing/squashing game?). |
Nah this is fine, thanks again! |
Thanks! When can I expect this to be released (e.g. to use it in nix)? |
Would it be possible for nix to use a git version of libc for now? I can be sure to make a release right before a nix release, but we just made a release yesterday I believe for another nix-requested PR :) |
That being said, I certainly don't mind making another release! |
Filed nix-rust/nix#387 for nix to track libc's master |
Thanks! I'll add some comments over there as well. |
Looks like LLVM 6 may have removed the intrinsic, and this implementation is modeled after clang's.
Add declarations from
sys/reboot.h
andlinux/reboot.h
. Initially originated as nix-rust/nix#386.