Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haiku: add getentropy #3991

Merged
merged 1 commit into from
Nov 6, 2024
Merged

haiku: add getentropy #3991

merged 1 commit into from
Nov 6, 2024

Conversation

devnexen
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Oct 19, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@devnexen
Copy link
Contributor Author

@rustbot label stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Oct 19, 2024
@tgross35
Copy link
Contributor

Looks straightforward enough to me, @nielx could you double check this?

@nielx
Copy link
Contributor

nielx commented Oct 27, 2024

@devnexen No objections to adding getentropy(), however I think the place is incorrect. The commit you cite actually moved this out of libbsd into the general libroot. However, in this change, you place it in the block that links to bsd. While this will not cause any problems in practise, I suggest it is placed outside of this block to match Haiku.

@nielx
Copy link
Contributor

nielx commented Oct 28, 2024

@tgross35 looks good to me!

@tgross35
Copy link
Contributor

Thanks for reviewing! I am just holding off on merging anything until FreeBSD comes back (rustc broke, should be fixed in this nightly or the next one)

@devnexen
Copy link
Contributor Author

Thanks for reviewing! I am just holding off on merging anything until FreeBSD comes back (rustc broke, should be fixed in this nightly or the next one)
Seems working now.

@tgross35 tgross35 changed the title haiku adding getentropy. haiku: add getentropy Nov 6, 2024
@tgross35 tgross35 enabled auto-merge November 6, 2024 18:54
@tgross35 tgross35 added this pull request to the merge queue Nov 6, 2024
Merged via the queue into rust-lang:main with commit f3152ef Nov 6, 2024
42 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 6, 2024
@tgross35 tgross35 mentioned this pull request Nov 6, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants