Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not re-export c_void in target-specific code #4200

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 17, 2024

Description

It is already re-exported at top-level.

pub use core::ffi::c_void;

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 enabled auto-merge December 17, 2024 11:38
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into rust-lang:main with commit 5f0d017 Dec 17, 2024
45 checks passed
@taiki-e taiki-e deleted the c-void branch December 17, 2024 12:13
@taiki-e taiki-e mentioned this pull request Dec 17, 2024
3 tasks
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 18, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Dec 18, 2024
@tgross35 tgross35 mentioned this pull request Dec 18, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants