Skip to content

Commit

Permalink
Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress
Browse files Browse the repository at this point in the history
when the binary loaded in memory has a section that we cannot find
in the on-disk version.  I added this warning out of an overabundance
of caution originally, but I've never seen an instance of it being
hit in the past few years, and there are some changes for the shared
cache on darwin systems where a segment is added when the shared
cache is constructed so we're now hitting this warning.  I've decided
to remove it altogether.

<rdar://problem/46889346> 

llvm-svn: 352158
  • Loading branch information
jasonmolenda committed Jan 25, 2019
1 parent 1b1e685 commit 9073eb4
Showing 1 changed file with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -255,15 +255,7 @@ bool DynamicLoaderDarwin::UpdateImageLoadAddress(Module *module,

changed = m_process->GetTarget().SetSectionLoadAddress(
section_sp, new_section_load_addr, warn_multiple);
} else {
Host::SystemLog(
Host::eSystemLogWarning,
"warning: unable to find and load segment named '%s' at "
"0x%" PRIx64 " in '%s' in macosx dynamic loader plug-in.\n",
info.segments[i].name.AsCString("<invalid>"),
(uint64_t)new_section_load_addr,
image_object_file->GetFileSpec().GetPath().c_str());
}
}
}
}

Expand Down

0 comments on commit 9073eb4

Please sign in to comment.