Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Support] PR42623: Avoid setting the delete-on-close bit if a… #92

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Feb 26, 2021

… TempFile doesn't reside on a local drive"

This reverts commit 6ec777c, which was
cherry picked to 11.x from 79657e2.

The change regressed on Windows 7 -- rust-lang/rust#81051

… TempFile doesn't reside on a local drive"

This reverts commit 6ec777c, which was
cherry picked to 11.x from 79657e2.

The change regressed on Windows 7 -- rust-lang/rust#81051
@cuviper
Copy link
Member Author

cuviper commented Feb 26, 2021

I know rust master is about to move to LLVM 12, but we'll need this on beta to avoid regressing Windows 7 in Rust 1.51. It looks like a direct update to beta would also pull in #90 -- is that OK? Otherwise I can push the revert to a new branch for 1.51.

cc @nagisa @nikic

@nagisa
Copy link
Member

nagisa commented Feb 26, 2021

We need the same revert for LLVM12, right?

I think its fine to backport #90 too, it is only relevant to unstable functionality (-Csplit-debuginfo=packed requires -Z unstable-options)

@cuviper
Copy link
Member Author

cuviper commented Feb 26, 2021

OK, I opened #93 for LLVM 12.

@nikic nikic merged commit 96ae895 into rust-lang:rustc/11.0-2021-01-05 Feb 27, 2021
@cuviper cuviper deleted the rust-81051 branch April 9, 2021 00:29
vext01 pushed a commit to vext01/llvm-project that referenced this pull request Oct 13, 2023
92: Remove pthread_create error from ShadowStack r=ltratt a=Pavel-Durov



Co-authored-by: Pavel Durov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants