Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header.hbs #453

Closed
Havvy opened this issue Sep 26, 2017 · 3 comments
Closed

Add header.hbs #453

Havvy opened this issue Sep 26, 2017 · 3 comments
Labels
C-enhancement Category: Enhancement or feature request C-refactor Category: Code refactoring E-Easy Experience: Easy S-Wishlist Status: Wishlist

Comments

@Havvy
Copy link
Contributor

Havvy commented Sep 26, 2017

Both the second edition of The Rust Programming Language and The Rust Reference put up a warning at the top of each page. To do this, we currently have our own theme/index.hbs. While this works, it does sort of pin us to a specific release of mdbook. We can occasionally rebase against index.hbs, but that has to be remembered to be done and takes away time from working on other things.

It'd be nice if there was a theme/header.hbs that we could override instead. Then at least the Rust Reference wouldn't need to override index.hbs, and TRPL would have a lot smaller diff to rebase with.

@budziq
Copy link
Contributor

budziq commented Sep 27, 2017

Actually I was thinking about the exact same feature for some time to split the index.hbs into few sections with default implementation. Candidates for such extraction would probably be:

  • sidebar
  • button bar (this one actoulalby be required by "Rust Cookbook")
  • header (needed by "The Rust Programming Language" and "The Rust Reference")
  • footer

@steveklabnik
Copy link
Member

The Cookbook also does this, but for othe things.

@azerupi azerupi added E-Easy Experience: Easy S-Wishlist Status: Wishlist C-enhancement Category: Enhancement or feature request C-refactor Category: Code refactoring labels Sep 27, 2017
Michael-F-Bryan added a commit that referenced this issue Dec 2, 2017
Adding a header partial integration #453
@Havvy
Copy link
Contributor Author

Havvy commented Dec 3, 2017

This has been fixed. 😄

@Havvy Havvy closed this as completed Dec 3, 2017
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement or feature request C-refactor Category: Code refactoring E-Easy Experience: Easy S-Wishlist Status: Wishlist
Projects
None yet
Development

No branches or pull requests

4 participants