Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some deps and bump MSRV to 1.51.0 #1719

Closed
wants to merge 3 commits into from

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jan 2, 2022

replace chrono by time v0.3 crate to mitigate RUSTSEC-2020-0159
headers v0.3.4 -> v0.3.5 to drop time 0.1 dep. Now only xml5ever depends on it, with unreleased patch
pretty_assertions v0.6 -> v0.7
clap v2.33.3 -> v2.34.0 to update to ansi_term 0.12
env_logger v0.7 -> v0.8 drops quick-error 1.2.3

@klensy
Copy link
Contributor Author

klensy commented Jan 2, 2022

Err, MSRV noted nowhere on repo page, but only checked on PR. Maybe add MSRV badge and/or note about it somewhere?

@ehuss
Copy link
Contributor

ehuss commented Jan 3, 2022

Ah, the documentation hasn't been published, yet, but the minimum version is documented here: https://github.com/rust-lang/mdBook/blob/master/guide/src/guide/installation.md

Can you determine what the new minimum is? It's fine to update it as long as it isn't too new.

@klensy
Copy link
Contributor Author

klensy commented Jan 3, 2022

Hm, didn't looked at this, looked around title page and https://github.com/rust-lang/mdBook/blob/master/CONTRIBUTING.md

With time 0.3.2 builds with rustc 1.48.0
With time 0.3.3+ (0.3.5 was used initially in this PR) builds with rustc 1.51.0

@ehuss
Copy link
Contributor

ehuss commented Jan 3, 2022

I think 1.51 should be fine, which is over 9 months old.

Can you also add a comment in main.yml to point to the documentation to update so they don't get out of sync?

klensy added 2 commits January 3, 2022 22:07
…nds on it, with unreleased patch

pretty_assertions v0.6 -> v0.7
clap v2.33.3 -> v2.34.0 to update to ansi_term 0.12
env_logger v0.7 -> v0.8 drops quick-error 1.2.3
@klensy klensy changed the title Update some deps Update some deps and bump MSRV to 1.51.0 Jan 3, 2022
@ehuss ehuss mentioned this pull request Mar 27, 2022
@ehuss
Copy link
Contributor

ehuss commented Mar 27, 2022

This looks like it has some test errors. Are you still interested in looking into it?

@ehuss
Copy link
Contributor

ehuss commented Jun 27, 2022

I'm going to close as this has become a bit stale.

@ehuss ehuss closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants