-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a set of default system font instead of webfont #716
Conversation
👍 Been meaning to do this for a long time. |
IMHO using a webfont locally hosted instead of Google-hosted would be better. Is there a reason why you'd rather not use Open Sans? |
I prefer Helvetica over Open Sans, because my eyes are more used to it. I don't like Open Sans's round-ish glyphs. |
I understand that, although I'm not sure if that alone is enough to justify the change. Having a consistent font is nice for this sort of thing. Personally, I'm not sure why mdbook uses Open Sans when it could be using Source Sans Pro. I personally much prefer its look, and it's open source. |
Does this qualify as "consistent"? |
I think @clarcharr might be referring to the incorporation of |
Makes sense. Though, my argument on this is that this set of system fonts provides a native looking, instead of aligning the same font everywhere. |
Yes, my definition of "consistent" was "same on every device" and not "similar to other services." While I feel that it doesn't matter a lot for Rust docs, one thing that web fonts solve is ensuring that websites aren't too disturbed by low-quality system fonts. Additionally, adding that uniformity means that you're not going to be too surprised by what something looks like on another system. The fact that Arial is at the end of this list makes me cringe, considering how despite the fact that it did its job very well at the time (looking well on low-pixel-density displays), it looks absolutely atrocious on modern systems. On my system, the only reason why this setup would look good at all is because I manually have Helvetica set to use Source Sans Pro instead, because the alternatives look absolutely atrocious to my eyes. Taking a good font (Open Sans) and replacing it with a Helvetica so that it looks good on your system isn't an excuse for making it look terrible on others. "I don't like Open Sans" is not really a compelling reason to get rid of it. If there's a genuine design thing, like making it look more readable, I'm all for it. But all things considered, Open Sans is a solid font, and this suggests switching to potentially terrible system alternatives. |
Since mdBook is used for Rust's official documentation I think it's a good idea to be fairly conservative in general, and removing external resources like these fonts would help with some edge cases:
Vendoring these fonts would be straightforward, and would solve 2 and 3. I'm still leaning towards removal since it would be simpler and the motivation to keep them is weak, IMO. It isn't important that mdBook uses the exact same fonts across devices. We don't have a strict brand identity we need to uphold, we just want to use some decent readable fonts. Reasonable people can disagree but most systems should (and do) have decent readable fonts at this point. You mentioned Arial which is not ideal but Segoe UI was introduced in Windows Vista so it shouldn't get used much. Arial could perhaps be removed entirely, since it likely isn't any better than the browser's default |
I'm going to close this, as it is pretty old. Also, the |
The reason is simple: I don't like Open Sans. The font set used in this PR is identical to GitHub's one.