Minor tweaks to the measureme::counters module. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleywiser
approved these changes
Nov 23, 2020
|
Oops forgot about this but I think it was landable since rust-lang/rust#78781 (comment). |
wesleywiser
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I meant to get these done before landing #143, but that happened too soon. Will keep this as draft until ready.
The inline
asm!changes I've validated by comparing the old and new versions (they produce identical assembly in godbolt set to "Intel dialect", i.e. the AT&T dialect gets parsed and rewritten to the Intel dialect I originally used).