Skip to content

Commit

Permalink
Auto merge of #127995 - workingjubilee:say-turings-prayer, r=BoxyUwU
Browse files Browse the repository at this point in the history
compiler: Never debug_assert in codegen

In the name of Turing and his Hoarey heralds, assert our truths before creating a monster!

The `rustc_codegen_llvm` and `rustc_codegen_ssa` crates are fairly critical for rustc's correctness. Small mistakes here can easily result in undefined behavior, since a "small mistake" can mean something like "link and execute the wrong code". We should probably run any and all asserts in these modules unconditionally on whether this is a "debug build", and damn the costs in performance.

...Especially because the costs in performance seem to be *nothing*. It is not clear how much correctness we gain here, but I'll take free correctness improvements.
  • Loading branch information
bors committed Jul 25, 2024
2 parents d50dee3 + 0a08705 commit c8b4e1c
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit c8b4e1c

Please sign in to comment.