New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokio io test #3848

Merged

bors merged 1 commit into rust-lang:master from tiif:tokiotest

Aug 28, 2024

Contributor

tiif commented Aug 27, 2024 •

edited

Loading

After #3804 landed, these tests passed.

tiif force-pushed the tokiotest branch from 253fc50 to 1df24ef Compare

August 28, 2024 02:23

tiif marked this pull request as ready for review

August 28, 2024 02:53

RalfJung reviewed

View reviewed changes

tests/pass-dep/tokio/mpsc.stdout Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

test_dependencies/Cargo.toml Show resolved Hide resolved

Member

RalfJung commented Aug 28, 2024 via email

Looks good :) please squash it into a single commit.

RalfJung reviewed

View reviewed changes

tests/pass-dep/tokio/mpsc.rs Outdated Show resolved Hide resolved

tiif force-pushed the tokiotest branch 2 times, most recently from 642e35d to e953e6d Compare

August 28, 2024 08:11

Contributor Author

tiif commented Aug 28, 2024 •

edited

Loading

~~Please don't r+ this first, I am not sure what's wrong with github, my local mpsc.rs has this, but github won't update it.~~

//@only-target-linux: support for tokio only on linux
use std::sync::mpsc::channel;

EDIT: Resolved, I didn't realise there is another mpsc.rs

tiif force-pushed the tokiotest branch from e953e6d to 4c00ac6 Compare

August 28, 2024 08:17

RalfJung reviewed

View reviewed changes

tests/pass/mpsc.rs Outdated Show resolved Hide resolved

tiif force-pushed the tokiotest branch from e84d0b6 to 7530aca Compare

August 28, 2024 08:28

RalfJung reviewed

View reviewed changes

tests/pass-dep/tokio/sleep.rs Outdated Show resolved Hide resolved

tiif force-pushed the tokiotest branch from 7530aca to c0ec222 Compare

August 28, 2024 08:39

tiif commented

View reviewed changes

tests/pass-dep/tokio/tokio_mvp.rs Outdated Show resolved Hide resolved


          Add test for tokio file io and mpsc

d1550bd

tiif force-pushed the tokiotest branch from c0ec222 to d1550bd Compare

August 28, 2024 08:44

Member

RalfJung commented Aug 28, 2024

Awesome. :)

Contributor

bors commented Aug 28, 2024

📌 Commit d1550bd has been approved by RalfJung

It is now in the queue for this repository.

Contributor

bors commented Aug 28, 2024

⌛ Testing commit d1550bd with merge 0974843...

Contributor

bors commented Aug 28, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 0974843 to master...

bors merged commit 0974843 into rust-lang:master

8 checks passed

tiif deleted the tokiotest branch

September 1, 2024 10:05

tiif mentioned this pull request

Open up more test for Miri tokio-rs/tokio#6812

Closed

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet