Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to make the Windows CI not rebuild Miri #750

Merged
merged 1 commit into from
May 29, 2019
Merged

Conversation

RalfJung
Copy link
Member

No description provided.

@RalfJung
Copy link
Member Author

Odd, seems like we are entirely starved for CI runners, both Travis and AppVeyor? Cc @rust-lang/infra

@pietroalbini
Copy link
Member

Yep, all the queues are filled.

@RalfJung
Copy link
Member Author

RalfJung commented May 29, 2019

Dang, that did not help. Cargo still is not doing the same feature resolution for the release build and the install job, but only on Windows. (Cc rust-lang/cargo#6983 and @ehuss, but I don't think this is worth deep investigation.)

Still, this change makes things more consistent with Travis, so I still think it is a good idea.

@RalfJung RalfJung merged commit a5224b0 into rust-lang:master May 29, 2019
@ehuss
Copy link
Contributor

ehuss commented May 29, 2019

Yea, you'll need to do the same investigation, this time with winapi, to see which additional features are enabled. Unfortunately winapi has dozens of features, and the set will probably change over time, so it will probably be more trouble than it's worth.

@RalfJung
Copy link
Member Author

RalfJung commented May 29, 2019

That rebuild is almost 20% of our Windows CI time. But yeah, without even having a Windows machine I am not going to attempt this.^^

@shepmaster
Copy link
Member

without even having a Windows machine

Microsoft offers free (time-limited) VMs which I use successfully for answering Windows-related Rust questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants