-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests on wasm32-unknown-unknown #80
Conversation
1861d87
to
fe45e0f
Compare
@alexcrichton this runs the full testsuite on wasm32-unknown-unknown except for the |
Having to use the I think we could have a tiny compiler That would make testing Rust crates for Obviously, the long term solution would be to use a custom test framework. |
https://travis-ci.org/rust-lang-nursery/packed_simd/jobs/416883709#L1479
This happens in debug builds. I am trying to run the tests in release mode to see if the issue persists. |
src/api/slice/write_to_slice.rs
Outdated
#[test] | ||
fn write_to_slice_unaligned() { | ||
#[cfg_attr(not(target_arch = "wasm32"), test)] #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] | ||
pub fn write_to_slice_unaligned() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the modules need to be publich (a known bug) you shouldn't need to use pub
on the methods themselves
Hm that basically means that there was an unresolved symbol, do you know if the test expect a symbol from libc or a C library or something like that? |
4a08295
to
cc74e3b
Compare
02dbb87
to
41e937e
Compare
It fails only in debug mode; in release everything works as expected. |
Closes #79