Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison functions #36

Closed
6 of 14 tasks
calebzulawski opened this issue Oct 12, 2020 · 2 comments · Fixed by #80
Closed
6 of 14 tasks

Comparison functions #36

calebzulawski opened this issue Oct 12, 2020 · 2 comments · Fixed by #80
Assignees
@calebzulawski

Comments

@calebzulawski
Copy link
Member

calebzulawski commented Oct 12, 2020 •
edited
Loading

Lanewise comparisons:

  • lanes_eq
  • lanes_ne
  • lanes_lt
  • lanes_le
  • lanes_gt
  • lanes_ge
  • is_positive/is_sign_positive
  • is_negative/is_sign_negative
  • is_finite
  • is_infinite
  • is_nan
  • is_normal

Other comparisons:

  • any_of/all_of
  • any_nan/all_nan

I'm open to different naming conventions of the lane comparisons, but I think it's best if they're not ambiguous with PartialEq etc. These functions may also be duplicated in traits if multiple mask widths end up being supported.
@calebzulawski calebzulawski added the I-nominated We should discuss this at the next weekly meeting label Oct 12, 2020
@calebzulawski calebzulawski self-assigned this Oct 12, 2020
@Lokathor
Copy link
Contributor

any_nan / all_nan makes sense. i'm not sure what any_of / all_of would do though.

@calebzulawski
Copy link
Member Author

Maybe needs a better name--it would check if any or all lanes equal a particular value.

@workingjubilee workingjubilee removed the I-nominated We should discuss this at the next weekly meeting label Oct 12, 2020
@calebzulawski calebzulawski mentioned this issue Oct 13, 2020
Closed
5 tasks
@calebzulawski calebzulawski mentioned this issue Feb 15, 2021
Closed
@calebzulawski calebzulawski mentioned this issue Mar 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebzulawski calebzulawski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add classification functions rust-lang/portable-simd
3 participants
@calebzulawski @Lokathor @workingjubilee