Use SIMD equality for PartialEq on SIMD vectors #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change implementing parallel
PartialEq
forSimd
vectors, fixing aTODO
. AllSimd
vectors by definition supportSimdPartialEq
, so the logic is copied.I currently think that the call to
simd_reduce_all
should indeed be round-tripped throughMask
to produce a proper integer vector, to handle odd architectures. I wasn't sure ifsimd_reduce_all(simd_eq(x, y))
was valid, in particular because the definition in LLVM appears to be bitwise AND, and I wasn't clear on where the reduction to Rustbool
takes place.