Mention tool lint attributes #446
Conversation
src/attributes.md
Outdated
| Tool lints let you use scoped lints, to `allow`, `warn`, `deny` or `forbid` lints of | ||
| certain tools. | ||
|
|
||
|
|
Manishearth
force-pushed
the
tool-attrs
branch
from
4e4396b to
afeeaab
Compare
|
This is okay as is. Don't take the rest of what I'm saying as a requirement to make changes, although do tell me if you want to make them. Otherwise, we can merge this as is (though it'd be nice to know Travis will pass...). With that out of the way, I think that tool lints don't need their own section. Instead, we need a more general section on lint check values that says both identifiers and |
Manishearth
force-pushed
the
tool-attrs
branch
from
afeeaab to
c604651
Compare
|
Slightly feel they should be in their own section, since the conditional checking of tool lints is important, prefer to merge as-is. Added an |
src/attributes.md
Outdated
| @@ -357,6 +357,35 @@ pub mod m3 { | |||
| } | |||
| ``` | |||
|
|
|||
| #### Tool lint attributes (`#[allow(clippy::foo)]`) | |||
There was a problem hiding this comment.
One nit before I merge: Everything in the parenthesis should not be in the header.
Manishearth
force-pushed
the
tool-attrs
branch
from
c604651 to
277b344
Compare
|
done
-Manish Goregaokar
…On Mon, Oct 15, 2018 at 11:36 PM Ryan Scheel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/attributes.md
<#446 (comment)>
:
> @@ -357,6 +357,35 @@ pub mod m3 {
}
```
+#### Tool lint attributes (`#[allow(clippy::foo)]`)
One nit before I merge: Everything in the parenthesis should not be in the
header.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#446 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABivSMC47-PD4eVlvUciUAK0L6Wa4Mhsks5ulX6BgaJpZM4XUVED>
.
|
|
💟 Thanks! |
Being stabilized in rust-lang/rust#54870 , wanted to preserve some documentation. Clippy has more docs on this.
r? @steveklabnik