Fixes a performance bug in bytes::Regex::replace. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was using `Vec::extend` to accumulate bytes in a buffer, but this compiles down to less efficient code than, say, `Vec::extend_from_slice`. However, that method is newly available as of Rust 1.6, so we do a small backport to regain performance. This bug was noticed by @llogiq here: TeXitoi/benchmarksgame-rs#31 In particular, this increases the performance of bytes::Regex two-fold on that benchmark.
|
@alexcrichton I know I'm really pushing it with this Rust 1.3 business. :-) An alternative (which would let us omit the |
|
Looks good to me! |
|
@BurntSushi Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was using
Vec::extendto accumulate bytes in a buffer, but thiscompiles down to less efficient code than, say,
Vec::extend_from_slice.However, that method is newly available as of Rust 1.6, so we do a small
backport to regain performance.
This bug was noticed by @llogiq here: TeXitoi/benchmarksgame-rs#31
In particular, this increases the performance of bytes::Regex two-fold on
that benchmark.