Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PartialEq impl for Regex (fixes #178) #212

Closed
wants to merge 1 commit into from

Conversation

wesleywiser
Copy link
Member

No description provided.

@wesleywiser
Copy link
Member Author

wesleywiser commented Apr 23, 2016

First time contributor to regex so if I've messed something up, please let me know 😄

@BurntSushi
Copy link
Member

@wesleywiser This looks great! Thank you! So there are two problems. One is that #178 is part of the 1.0 milestone and is also a breaking change, so we can't quite land it yet. The other problem is that my set of issues for the 1.0 milestone roughly corresponds to things that I want to address in the regex 1.0 RFC, which means it hasn't actually been decided yet whether we're going through with said changes.

I'm really sorry about the confusion---I didn't really think too much about how this organization might look to new contributors! How about we leave this PR open, and if we do decide to take it, I'll merge it in then?

@wesleywiser
Copy link
Member Author

No problem! If you want to leave this open or close it, either is fine.

@BurntSushi
Copy link
Member

Great! I'll leave it open. Thanks again!

@BurntSushi BurntSushi closed this May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants