regex 1.0 #230
Closed
regex 1.0 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Nice! Would it make sense to draw up a short summary of the breaking changes from the current 0.1 release train? |
|
@alexcrichton Oh yes, that will be in the RFC. I can add the relevant pieces to the commit messages too. It's a WIP. :-) |
BurntSushi
force-pushed
the
rfc
branch
2 times, most recently
from
c4f0655 to
135b1e9
Compare
|
You should also consider raising the minimum Rust version. For example, regex currently requires Rust 1.4 on Windows. |
|
@RustPowers Please comment on the RFC instead: rust-lang/rfcs#1620 (The |
It is useless because it will always return false (since every regex has at least one capture group corresponding to the full match). Fixes #179
It is misleading to suggest that Regex implements equality, since equality is a well defined operation on regular expressions and this particular implementation doesn't correspond to that definition at all. Moreover, I suspect the actual use cases for such an impl are rather niche. A simple newtype+deref should resolve any such use cases. Fixes #178
This corrects a gaffe of mine. In particular, both types contain references to a `Captures` *and* the text that was searched, but only names one lifetime. In practice, this means that the shortest lifetime is used, which can be problematic for when one is trying to extract submatch text. This also fixes the lifetime annotation on `iter_pos`, which should be tied to the Captures and not the text. It was always possible to work around this by using indices. Fixes #168
This is replaced by using RegexBuilder. Fixes #166
It encourages compiling a regex for every use, which can be convenient in some circumstances but deadly for performance. Fixes #165
Similarly, rename RegexSplitsN to SplitsN. This follows the convention of all other iterator types. In general, we shouldn't namespace our type names.
Mostly, this adds an `Iter` suffix to all of the names.
These are tested automatically.
If `replace` doesn't find any matches, then it can return the original string unchanged.
This remove the InvalidSet variant, which is no longer used, and no longer exposes the `regex_syntax::Error` type, instead exposing it as a string.
BurntSushi
force-pushed
the
rfc
branch
2 times, most recently
from
a82a96b to
aba9c28
Compare
This also removes Captures.{at,pos} and replaces it with Captures.get,
which now returns a Match. Similarly, Captures.name returns a Match as
well.
All use cases can be replaced with Regex::capture_names.
Weird that this cfg_attrs didn't get pulled in during the rebase...
BurntSushi
force-pushed
the
rfc
branch
3 times, most recently
from
4fc851e to
44bcbce
Compare
Specifically, use mutable references instead of passing ownership.
|
Ping. rust-lang/rfcs#1620 was approved last month. Any plan on regex 1.0? |
|
Closing in favor of #310. |
|
Is regex going to be part of std, or would it remain an independent crate that developers would still need to specify in |
|
@upsuper There are no plans to move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of commits corresponding to my proposed changes for regex 1.0. It's still a work in progress and shouldn't be merged until an RFC is accepted.