RegexSet: fix literal optimization bug #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When combining multiple regexes in a set where some are anchored and others aren't, it's possible to wind up in a situation where prefix scanning is used. This is bad, because it can lead to some of the anchored regexes matching where they shouldn't be allowed to match. As a result, we disable all literal optimizations for regex sets if *any* regex in the set is anchored. Fixes rust-lang#358
|
@bors r+ |
|
📌 Commit be9653c has been approved by |
bors
added a commit
that referenced
this pull request
May 20, 2017
RegexSet: fix literal optimization bug When combining multiple regexes in a set where some are anchored and others aren't, it's possible to wind up in a situation where prefix scanning is used. This is bad, because it can lead to some of the anchored regexes matching where they shouldn't be allowed to match. As a result, we disable all literal optimizations for regex sets if *any* regex in the set is anchored. Fixes #358
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When combining multiple regexes in a set where some are anchored and
others aren't, it's possible to wind up in a situation where prefix
scanning is used. This is bad, because it can lead to some of the
anchored regexes matching where they shouldn't be allowed to match.
As a result, we disable all literal optimizations for regex sets if
any regex in the set is anchored.
Fixes #358