Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PartialEq impl for Regex. #378

Closed
wants to merge 1 commit into from
Closed

Conversation

remexre
Copy link
Contributor

@remexre remexre commented Jun 1, 2017

This simply compares the two regexes' strings, as the same string should always produce the same regex.

@BurntSushi
Copy link
Member

Thanks, but this was explicitly dropped in regex 0.2 because regex equivalence is not determined by their concrete syntax. See #178, #313 and #364

@BurntSushi BurntSushi closed this Jun 1, 2017
@remexre remexre deleted the partialeq branch June 1, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants