Skip to content

Commit

Permalink
Addressing some comments on the libstd facade
Browse files Browse the repository at this point in the history
  • Loading branch information
alexcrichton committed Apr 10, 2014
1 parent ee93546 commit b7f346e
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions active/0000-libstd-facade.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ many locations.
#### Strings

In a post-DST world, the string type will actually be a library-defined type,
`Str` (or similarly named). Strings will no longer be a lanuage item or a
`Str` (or similarly named). Strings will no longer be a lanuage feature or a
language-defined type. This implies that any methods on strings must be in the
same crate that defined the `Str` type, or done through extension traits.

Expand Down Expand Up @@ -129,7 +129,7 @@ Inclusion of this module is the reason why I/O is included in the module as well
to no overhead required in terms of dependencies.

Neither `print!` nor `format!` macros to be a part of this library, but the
`write!` macro to be present.
`write!` macro would be present.

#### I/O

Expand Down Expand Up @@ -397,7 +397,8 @@ various environments seems beneficial.
* Compile times. It's possible that having so many upstream crates for each rust
crate will increase compile times through reading metadata and invoking the
system linker. Would sharding crates still be worth it? Could possible
problems that arise be overcome?
problems that arise be overcome? Would extra monomorphization in all these
crates end up causing more binary bloat?

* Binary bloat. Another possible side effect of having many upstream crates
would be increasing binary bloat of each rust program. Our current linkage
Expand Down

0 comments on commit b7f346e

Please sign in to comment.