Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new RFC: static_lifetime_in_statics #1623

Merged
merged 5 commits into from
Aug 22, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions text/0000-static.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
- Feature Name: static_lifetime_in_statics
- Start Date: 2016-05-20
- RFC PR: (leave this empty)
- Rust Issue: (leave this empty)

# Summary
[summary]: #summary

Let's default lifetimes in static and const declarations to `'static`.

# Motivation
[motivation]: #motivation

Currently, having references in `static` and `const` declarations is cumbersome
due to having to explicitly write `&'static ..`. On the other hand anything but
static is likely either useless, unsound or both. Also the long lifetime name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote, since 'static is the only name in scope, it's certainly not "unsound" -- other names are just a guaranteed compilation error. I'd just drop this sentence.

causes substantial rightwards drift, which makes it hard to format the code
to be visually appealing.

For example, having a `'static` default for lifetimes would turn this:
```
static my_awesome_tables: &'static [&'static HashMap<Cow<'static, str>, u32>] = ..
```
into this:
```
static my_awesome_table: &[&HashMap<Cow<str>, u32>] = ..
```

The type declaration still causes some rightwards drift, but at least all the
contained information is useful.

# Detailed design
[design]: #detailed-design

The same default that RFC #599 sets up for trait object is to be used for
statics and const declarations. In those declarations, the compiler will assume
`'static` when a lifetime is not explicitly given in both refs and generics.

Note that this RFC does not forbid writing the lifetimes, it only sets a
default when no is given. Thus the change is unlikely to cause any breakage and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say "unlikely": I believe is completely backwards compatible.

should be deemed backwards-compatible. It's also very unlikely that
implementing this RFC will restrict our design space for `static` and `const`
definitions down the road.

# Drawbacks
[drawbacks]: #drawbacks

There are no known drawbacks to this change.

# Alternatives
[alternatives]: #alternatives

* Leave everything as it is. Everyone using static references is annoyed by
having to add `'static` without any value to readability. People will resort to
writing macros if they have many resources.
* Write the aforementioned macro. This is inferior in terms of UX. Depending on
the implementation it may or may not be possible to default lifetimes in
generics.
* Infer types for statics. The absence of types makes it harder to reason about
the code, so even if type inference for statics was to be implemented,
defaulting lifetimes would have the benefit of pulling the cost-benefit
relation in the direction of more explicit code. Thus it is advisable to
implement this change even with the possibility of implementing type inference
later.

# Unresolved questions
[unresolved]: #unresolved-questions

* Does this change requires changing the grammar?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, unless you had a distinct grammar for types in statics, which we do not and would not, I don't think.

* Are there other Rust-code handling programs that need to be updated?