Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "artifact dependencies" on bin, cdylib, and staticlib crates #3028

Merged
merged 34 commits into from
Jan 23, 2021
Merged

Allow "artifact dependencies" on bin, cdylib, and staticlib crates #3028

Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b921f08
Add RFC for dependencies on binaries
jyn514 Nov 30, 2020
fac809f
Clarify what `lib` means
jyn514 Dec 1, 2020
d45fb22
Add note about the alternative of a hardcoded binary path
joshtriplett Dec 8, 2020
0670af0
Add SPIR-V shaders as an example
joshtriplett Dec 13, 2020
9bc481d
Clarify that type and crate name transformations happen in both cases
joshtriplett Dec 13, 2020
1056622
Move long multi-sentence parenthetical to a sub-bullet
joshtriplett Dec 13, 2020
c6fde3c
Change the case for omitting the artifact suffix
joshtriplett Dec 13, 2020
b06d9cb
Discuss interaction with hypothetical automatic handling of staticlib…
joshtriplett Dec 13, 2020
42ae02f
Remove trailing space
joshtriplett Dec 13, 2020
8faaab8
Discuss alternative of omitting `"lib"`
joshtriplett Dec 14, 2020
6d95b60
Add note about handling of cross-compiled artifact dependencies
joshtriplett Dec 14, 2020
2e1aabf
We may want `env_os!` or `env_path!`
joshtriplett Dec 14, 2020
32f1a50
Remove unclear use case
jyn514 Dec 16, 2020
983638e
Elaborate on the use case for depending on a binary
joshtriplett Dec 16, 2020
c547a58
Add a use case for tools needed for testing
joshtriplett Dec 16, 2020
22c8a57
Mention Swift packages and "products"
joshtriplett Dec 16, 2020
9aebb5a
Remove a link from the use cases; the text explains the use case better
joshtriplett Dec 16, 2020
c46b068
Discuss alternative of recursive cargo or alternative build systems
joshtriplett Dec 16, 2020
442dcb0
Clarify a mention of "binary" to cover other artifact types
joshtriplett Dec 16, 2020
4e6f6ea
Provide an example for the artifact name matching the crate name
joshtriplett Dec 16, 2020
7f51fc4
Change `type` to `artifact` everywhere, and split out "lib"
joshtriplett Dec 16, 2020
58577cb
Use "artifact dependency" consistently, for clarity
joshtriplett Dec 17, 2020
ff2b254
Drop `bins` in favor of `artifact = "bin:name"`
joshtriplett Dec 17, 2020
82baedf
Elaborate on the LD_PRELOAD and VDSO use cases
joshtriplett Dec 17, 2020
0f3933b
Minor grammar tweak
joshtriplett Dec 17, 2020
6c84436
Clarify scope statement
joshtriplett Dec 17, 2020
eaf80fb
Add a cross-reference from drawbacks to alternatives
joshtriplett Dec 17, 2020
be85559
Expand an example
joshtriplett Dec 17, 2020
93c3094
Adjust a missed `<CRATE>` to `<DEP>` to match the rest
joshtriplett Dec 17, 2020
c9470ad
Document alternative syntaxes for specifying dependencies on specific…
joshtriplett Dec 17, 2020
a42fead
Propose specific artifact paths for the implementation
joshtriplett Dec 17, 2020
98e1476
Document the profile settings used to build artifact dependencies
joshtriplett Dec 17, 2020
2ddc224
Document what happens when building for multiple targets at once
joshtriplett Dec 24, 2020
278de5a
Merging RFC 3028
ehuss Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading