rls does not cope with non-numeric strings as request ids

[Trolldemorted]

According to the protocol, request ids may either be numbers or strings.

rls panics here because serde_json returns none if the value is a string.

[nrc]

Hmm, I thought we fixed this ages ago, but it must be my imagination - I can't even find another issue.

[Trolldemorted]

Maybe it was at some other place in the code?

Sent you a PR, appears to work fine (at least on W10).

[Xanewok]

This would probably by fixed when gluon-lang/lsp-types#19 and related serialization lands.

[Trolldemorted]

👍, lsp4j is now working with rls out-of-the-box!

However, sending a non-numeric string id to rls does not work (#361 (comment)).

[sophiajt]

@Trolldemorted - I think this is expected? I thought the string vs number was so that numbers could be sent in either format, not that arbitrary strings would be accepted.

[Trolldemorted]

The protocol does not say numeric strings, just number or strings. I think that it is very unlikely that someone sends foo as an id, but according to the protocol specification it would be ok.