Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Make WAIT_TO_BUILD configurable #364

Closed
nrc opened this issue Jun 20, 2017 · 7 comments
Closed

Make WAIT_TO_BUILD configurable #364

nrc opened this issue Jun 20, 2017 · 7 comments

Comments

@nrc
Copy link
Member

nrc commented Jun 20, 2017

This is the time between receiving a change notification and starting building. For users with low-end hardware they might want to make this longer (see editor-rs/vscode-rust#272).

We should add a config option and use that in build.rs rather than the constant WAIT_TO_BUILD.

@robbym
Copy link
Contributor

robbym commented Jul 3, 2017

Hi, I'm new to RLS. I'd like to help contribute.

This would be configured via rls.toml? Or command line option?

I'll continue to read through the code to try and understand how this would be implemented though.

@robbym
Copy link
Contributor

robbym commented Jul 3, 2017

Something like this? robbym@3294017

@robbym
Copy link
Contributor

robbym commented Jul 3, 2017

Interesting though. I set the time to 5000ms in the rls.toml.

I tapped the space bar, "Analysis started", 5 seconds later, "Analysis finished". No problem.

But, if I keep tapping within the 5 second interval, like every second for example, it still goes to "Analysis finished" 5 seconds after the initial tap.

I imagined the WAIT_TO_BUILD thing worked like this: You tap a button, the timer starts, and every time you tap a button the timer resets, and when that timer reaches 0, run the build.

This doesn't seem to be the case.

EDIT: Just noticed that this is related to #339

@nrc
Copy link
Member Author

nrc commented Jul 4, 2017

@robbym That looks great, could you submit a PR (I have a couple of minor points, but easier to put them in a review than here). Yep, #339 covers the reasoning for the current behaviour. I should document that in-tree.

@nrc
Copy link
Member Author

nrc commented Jul 4, 2017

Oh, and thanks for jumping on this!

@robbym
Copy link
Contributor

robbym commented Jul 4, 2017

Np. PR is up.

@nrc
Copy link
Member Author

nrc commented Jul 4, 2017

Fixed by #391

@nrc nrc closed this as completed Jul 4, 2017
bors added a commit that referenced this issue Feb 1, 2019
… r=alexheretic

Bump jsonrpc-core from 9.0.0 to 10.0.1

Bumps [jsonrpc-core](https://github.com/paritytech/jsonrpc) from 9.0.0 to 10.0.1.
<details>
<summary>Release notes</summary>

*Sourced from [jsonrpc-core's releases](https://github.com/paritytech/jsonrpc/releases).*

> ## JSON-RPC v10.0.1
> Fixes documentation links and authors.
>
> ```
> jsonrpc-core = "10.0.1"
> jsonrpc-macros = "10.0.1"
> jsonrpc-derive = "10.0.1"
> jsonrpc-pubsub = "10.0.1"
> jsonrpc-server-utils = "10.0.1"
> jsonrpc-http-server = "10.0.1"
> jsonrpc-ipc-server = "10.0.1"
> jsonrpc-tcp-server = "10.0.1"
> jsonrpc-ws-server = "10.0.1"
> jsonrpc-stdio-server = "10.0.1"
> jsonrpc-test = "10.0.1"
> ```
>
> ## JSON-RPC v10.0.0
> This is an exciting release, because it's the first time we release all parts of the suite to crates.io! So long github dependencies!
>
> Most notable changes:
> 1. Deprecating `jsonrpc-macros` in favour of `jsonrpc-derive` (proc-macro based)
> 2. Rewrting all crates to `edition = 2018`
>
> Other changes:
> - Adding `Metadata` to unsubscribe methods (when they are called explicitly)
> - Derive `Clone` for all `core` types
> - Fix custom bounds on the types in `jsonrpc-macros`
> - Fix charset case sensitivity for http server
>
>
> Full list of changes: paritytech/jsonrpc@v9.0.0...v10.0.0
>
> ```
> jsonrpc-core = "10.0.0"
> jsonrpc-macros = "10.0.0"
> jsonrpc-pubsub = "10.0.0"
> jsonrpc-server-utils = "10.0.0"
> jsonrpc-http-server = "10.0.0"
> jsonrpc-ipc-server = "10.0.0"
> jsonrpc-tcp-server = "10.0.0"
> jsonrpc-ws-server = "10.0.0"
> jsonrpc-stdio-server = "10.0.0"
> jsonrpc-test = "10.0.0"
> ```
</details>
<details>
<summary>Commits</summary>

- [`8ffc7f3`](paritytech/jsonrpc@8ffc7f3) Add jsonrpc-derive details. ([#372](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/372))
- [`2fe3bfc`](paritytech/jsonrpc@2fe3bfc) One way serialize for subscriber type ([#371](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/371))
- [`37b62a3`](paritytech/jsonrpc@37b62a3) Migrate to edition 2018 ([#368](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/368))
- [`5a7be5f`](paritytech/jsonrpc@5a7be5f) Bump version of stdio ([#367](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/367))
- [`2b47a5c`](paritytech/jsonrpc@2b47a5c) Use parity-ws-rs from crates.io ([#361](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/361))
- [`8160eb5`](paritytech/jsonrpc@8160eb5) ci: bring appveyor back ([#364](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/364))
- [`80205d4`](paritytech/jsonrpc@80205d4) Support multiple trailing arguments ([#365](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/365))
- [`ec5249e`](paritytech/jsonrpc@ec5249e) Use procedural macros  ([#340](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/340))
- [`789c74d`](paritytech/jsonrpc@789c74d) Derive Clone for all core types::* ([#359](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/359))
- [`16ed9f5`](paritytech/jsonrpc@16ed9f5) Fix tokio deprecation warnings ([#358](https://github-redirect.dependabot.com/paritytech/jsonrpc/issues/358))
- Additional commits viewable in [compare view](paritytech/jsonrpc@v9.0.0...v10.0.1)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=jsonrpc-core&package-manager=cargo&previous-version=9.0.0&new-version=10.0.1)](https://dependabot.com/compatibility-score.html?dependency-name=jsonrpc-core&package-manager=cargo&previous-version=9.0.0&new-version=10.0.1)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants