This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Update Cargo in the RLS #1063
Merged
Update Cargo in the RLS #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the fallout of rust-lang/rust#54334
alexcrichton
commented
Sep 22, 2018
| }; | ||
| let mut pkg_id_to_pkg = HashMap::new(); | ||
| let mut manifest_to_id = HashMap::new(); | ||
| let mut packages = Vec::new(); | ||
| for (idx, pkg_id) in resolve.iter().enumerate() { | ||
| let pkg = Package(idx); | ||
| pkg_id_to_pkg.insert(pkg_id.clone(), pkg); | ||
| let cargo_pkg = cargo_packages.get(pkg_id)?; | ||
| let cargo_pkg = cargo_packages.get_one(pkg_id)?; |
There was a problem hiding this comment.
Note that the breakge here stems from rust-lang/cargo#6005 where Cargo can now download crates in parallel. The get_one is the (now renamed) old synchronous interface, and RLS likely wants to try using the new get_many interface to leverage parallel downloads. For now though I've left it as-is to hopefully get the regression fixed quickly, and this could perhaps be a future follow-up!
There was a problem hiding this comment.
Maybe leave a FIXME or open an issue so this isn't forgotten?
|
Thanks! I'll open a follow-up issue to the mentioned parallel downloads. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the fallout of rust-lang/rust#54334