This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Collect file -> edition mapping after AST expansion #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #1519) made this pull request unmergeable. Please resolve the merge conflicts. |
Xanewok
force-pushed
the
collect-files-after-expansion
branch
from
ef31716 to
34d8df7
Compare
Xanewok
force-pushed
the
collect-files-after-expansion
branch
2 times, most recently
from
e353b47 to
4586c35
Compare
Reason for that being so that non-syntax errors should still allow us to reason about which file belongs to a given crate, which specifically allows us to run a formatter even if the code contains type errors or similar.
Xanewok
force-pushed
the
collect-files-after-expansion
branch
from
4586c35 to
04ae465
Compare
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 4, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 6, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Aug 8, 2019
Update RLS Most importantly this includes: * Collect file -> edition mapping after AST expansion ([#1513](rust-lang/rls#1513)) (enabled by #62679) * Fix rustfmt during builds by reading edition from manifest ([#1533](rust-lang/rls#1533)) Which fixes the annoying problem where users couldn't format via RLS while `cargo fmt` worked. The beta cut-off is drawing near and I'd like to make sure this lands before then.
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 13, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 13, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 13, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 13, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 13, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 13, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Xanewok
added a commit
to Xanewok/rls
that referenced
this pull request
Aug 13, 2019
Applies the equivalent of rust-lang#1513 in the out-of-process compilation case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for that being so that non-syntax errors should still allow us to reason about which file belongs to a given crate, which specifically allows us to run a formatter even if the code contains type errors or similar.
Should make the formatter Just Work^TM in the cases where it could've technically worked before (e.g. no syntax errors).
Requires rust-lang/rust#62679