This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Simplify outgoing notifications, remove NoParams #603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #602. Since I'll want use different notifications (
window/showMessage
) than the currently hardcoded PublishDiagnostics andrustDocument/*
ones, I tried to generalize theOutput::notify
, which is now easily possibly thanks toAction
trait (thanks @alexheretic!).The trait is generic enough (provides method and params type) to be easily reused, but it's not as clean as it could be - per documentation implementers are messages handled by the server (so client->server), whereas I added implementation of the ones sent to the client instead.
Ideally this should be solved using gluon-lang/lsp-types#19 (which I didn't do yet... 😢 ).
Additionally replaced
NoParams
with()
, as these serve the same purpose and not to introduce another custom type.r? @nrc