Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: un-inline ConstScalarOrPath::from_expr_opt #12785

Merged

Conversation

Logarithmus
Copy link
Contributor

@Logarithmus Logarithmus commented Jul 17, 2022

Sorry, but I missed these from #12778 @flodiebold

@Veykril
Copy link
Member

Veykril commented Jul 17, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 17, 2022

📌 Commit d9336a4 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 17, 2022

⌛ Testing commit d9336a4 with merge 897a7ec...

@bors
Copy link
Contributor

bors commented Jul 17, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 897a7ec to master...

@bors bors merged commit 897a7ec into rust-lang:master Jul 17, 2022
@lnicola
Copy link
Member

lnicola commented Jul 18, 2022

I'm not sure why it would be so, but this might have slowed down the analysis?

image

(from https://rust-analyzer.github.io/metrics/?start=2022-07-11&end=)

@flodiebold
Copy link
Member

Yeah, seems very unlikely. Let's see whether it stays that way...

@Veykril
Copy link
Member

Veykril commented Jul 18, 2022

Looks like that was just unfortunate CI times, the graph looks normal again
image

@Logarithmus Logarithmus deleted the feature/fix-negative-const-generics branch July 18, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants