fix: use BoundVars from current generic scope
#13344
Conversation
|
I ran analysis-stats on the four crates used in metrics and on std (no crash and no change in numbers), are there other crates I should ran it on? |
|
I don't think so, thanks again! |
fix: use `BoundVar`s from current generic scope Fixup for #13335, addresses #13339 (comment) Before the change in generic parameter order, `BoundVar`s for trait reference didn't change whether you are in an impl's scope or in an associated item's scope. Now that item's generic params come before its parent's, we need to shift their indices when we are in an associated item's scope.
|
☀️ Test successful - checks-actions |
|
Huh? @bors retry |
fix: use `BoundVar`s from current generic scope Fixup for #13335, addresses #13339 (comment) Before the change in generic parameter order, `BoundVar`s for trait reference didn't change whether you are in an impl's scope or in an associated item's scope. Now that item's generic params come before its parent's, we need to shift their indices when we are in an associated item's scope.
|
I believe this is due to me asking about the branch protection? https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/r-a.20branch.20protection |
|
☀️ Test successful - checks-actions |
|
Okay lets try after my approval now |
|
💡 This pull request was already approved, no need to approve it again.
|
fix: use `BoundVar`s from current generic scope Fixup for #13335, addresses #13339 (comment) Before the change in generic parameter order, `BoundVar`s for trait reference didn't change whether you are in an impl's scope or in an associated item's scope. Now that item's generic params come before its parent's, we need to shift their indices when we are in an associated item's scope.
|
Maybe bors can't push to |
|
☀️ Test successful - checks-actions |
|
(it was manually granted permissions, lets sneak it by before the next sync) |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-actions |
|
I'm pretty sure bors didn't like me breaking analysis-stats so bad 😭 Kidding, but I hope I fixed everything I broke! |
|
It fixes everything we run at least, so we should have some decent coverage (only people doing type crimes will prove us wrong here now) |
Fixup for #13335, addresses #13339 (comment)
Before the change in generic parameter order,
BoundVars for trait reference didn't change whether you are in an impl's scope or in an associated item's scope. Now that item's generic params come before its parent's, we need to shift their indices when we are in an associated item's scope.